[Mesa-dev] [Bug 43138] [glsl] fail to get the active attribute with function glGetProgramiv

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=43138

Ian Romanick <idr at freedesktop.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #7 from Ian Romanick <idr at freedesktop.org> 2011-11-29 11:15:53 PST ---
Fixed on master by the following commit.  The rationale for not backporting
this to 7.11 explained in comment #3 still applies.

commit e6c314f7d2ed99714376fec6b7509a55535fa3ff
Author: Ian Romanick <ian.d.romanick at intel.com>
Date:   Mon Nov 21 20:47:57 2011 -0800

    mesa: Allow generic attributes for glGetActiveAttrib and
GL_ACTIVE_ATTRIBUTE

    Page 77 (page 91 of the PDF) says about glGetActiveAttrib:

        "The returned attribute name can be the name of a generic
        attribute or a conventional attribute (which begin with the prefix
        "gl_", see the OpenGL Shading Language specification for a
        complete list)."

    Page 261 (page 275 of the PDF) says about glGetProgramiv:

        "If pname is ACTIVE_ATTRIBUTES, the number of active attributes in
        program is returned."

    It doesn't say anything about built-in vs. user-defined attributes.
    From the language around glGetActiveAttrib and the lack of an
    exclusion of built-in attributes, which exists other places (e.g.,
    around glBindAttribLocation), we can infer that GL_ACTIVE_ATTRIBUTES
    should include the active attribute count.  It should also be included
    in the values returned by glGetActiveAttrib.

    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=43138
    Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
    Reviewed-by: Eric Anholt <eric at anholt.net>
    Tested-by: Yi Sun <yi.sun at intel.com>

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.