[Mesa-dev] [PATCH 09/34] glsl: add ir_emitvertex and ir_endprim instruction types

[Paul Berry]

On 30 July 2013 11:08, Kenneth Graunke <kenneth at whitecape.org> wrote:

> On 07/28/2013 11:03 PM, Paul Berry wrote:
>
>> From: Bryan Cain <bryancain3 at gmail.com>
>>
>> These correspond to the EmitVertex and EndPrimitive functions in GLSL.
>>
>> v2 (Paul Berry <stereotype441 at gmail.com>): Add stub implementations of
>> new pure visitor functions to i965's vec4_visitor and fs_visitor
>> classes.
>>
>
> I would prefer to see these called:
>
> ir_emit_vertex
> ir_end_primitive
>
> The GLSL constructs are called EmitVertex and EndPrimitive, and so the
> obvious conversion from CamelCase to lowercase_with_underscores would
> result in ir_emit_vertex/ir_end_**primitive.
>
> I hate to make that suggestion, since it means a lot of pointless churn,
> but...somehow ir_emitvertex just bothers me every time I see it.


Yeah, I agree with you.  Consistency is good, and now is the best time to
achieve it since the series hasn't landed yet.  I'll make the changes you
suggest.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20130730/cc87b2e1/attachment.html>