[Mesa-dev] [PATCH 5/6] mesa: Fix missing setting of shader->IsES.
kenneth at whitecape.org
Tue Jun 18 04:13:32 PDT 2013
On 06/17/2013 04:10 PM, Eric Anholt wrote:
> I noticed this while trying to merge code with the builtin compiler, which
> does set it.
> Note that this causes two regressions in piglit in
> default-precision-sampler.* which try to link without a vertex or fragment
> shader, due to being run under the desktop glslparsertest binary (using
> ARB_ES3_compatibility) that doesn't know about this requirement.
That seems quite odd.
> src/mesa/program/ir_to_mesa.cpp | 1 +
> 1 file changed, 1 insertion(+)
> diff --git a/src/mesa/program/ir_to_mesa.cpp b/src/mesa/program/ir_to_mesa.cpp
> index 2739df7..a915974 100644
> --- a/src/mesa/program/ir_to_mesa.cpp
> +++ b/src/mesa/program/ir_to_mesa.cpp
> @@ -3155,6 +3155,7 @@ _mesa_glsl_compile_shader(struct gl_context *ctx, struct gl_shader *shader)
> shader->CompileStatus = !state->error;
> shader->InfoLog = state->info_log;
> shader->Version = state->language_version;
> + shader->IsES = state->es_shader;
> memcpy(shader->builtins_to_link, state->builtins_to_link,
> sizeof(shader->builtins_to_link) * state->num_builtins_to_link);
> shader->num_builtins_to_link = state->num_builtins_to_link;
It does seem like we ought to be setting this. So, regressions or not,
I think this is the right thing to do.
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
More information about the mesa-dev