[Mesa-dev] [PATCH 2/5] mesa/main: Add generic bits of ARB_clear_texture implementation

Neil Roberts neil at linux.intel.com
Tue Jul 1 10:11:50 PDT 2014


Ian Romanick <idr at freedesktop.org> writes:

> Are there potentially cases where the first clear_tex_image could
> succeed but the second fail?  If so, then this is no good.  If a GL call
> generates an error (other than GL_NO_MEMORY), it is supposed to be as
> though nothing happened.

Urgh, yes, you're right because for example GL would let you make one
face of a cubemap texture be compressed while the others aren't. I'll
change it to have a separate loop for the checks as you suggest.

Thanks for the review.

- Neil


More information about the mesa-dev mailing list