[Mesa-dev] [PATCH 2/5] mesa/main: Add generic bits of ARB_clear_texture implementation

Jason Ekstrand jason at jlekstrand.net
Tue Jul 1 11:25:38 PDT 2014

On Tue, Jul 1, 2014 at 10:09 AM, Neil Roberts <neil at linux.intel.com> wrote:

> Jason Ekstrand <jason at jlekstrand.net> writes:
> >> +   texImages[0] = _mesa_select_tex_image(ctx, texObj, texObj->Target,
> >> level);
> >>
> >
> > Do you want this inside an else block?
> I think it's quite a common idiom in Mesa to handle the special cases as
> a series of if-statements with a return upfront before handling the
> normal case at the end without an else. But yes, in this instance it
> does look a bit odd because the there is only one special case and the
> normal case is very short, so I don't mind changing it.

Sorry, I missed the return.  In that case, I don't think it matters; feel
free to leave it alone.

> Regards,
> - Neil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20140701/5c1d0712/attachment-0001.html>

More information about the mesa-dev mailing list