[Mesa-dev] [PATCH 2/2] gallium/docs: minor clarification for TXQ instruction

[Ilia Mirkin]

On Thu, Jul 10, 2014 at 1:13 PM, Brian Paul <brianp at vmware.com> wrote:
> On 07/10/2014 09:50 AM, Ilia Mirkin wrote:
>>
>> On Thu, Jul 10, 2014 at 11:46 AM, Ilia Mirkin <imirkin at alum.mit.edu>
>> wrote:
>>>
>>> On Thu, Jul 10, 2014 at 11:43 AM, Brian Paul <brianp at vmware.com> wrote:
>>>>
>>>> ---
>>>>   src/gallium/docs/source/tgsi.rst |    2 ++
>>>>   1 file changed, 2 insertions(+)
>>>>
>>>> diff --git a/src/gallium/docs/source/tgsi.rst
>>>> b/src/gallium/docs/source/tgsi.rst
>>>> index 8cbb3d8..c267b2c 100644
>>>> --- a/src/gallium/docs/source/tgsi.rst
>>>> +++ b/src/gallium/docs/source/tgsi.rst
>>>> @@ -968,6 +968,8 @@ XXX doesn't look like most of the opcodes really
>>>> belong here.
>>>>     Also return the number of accessible levels (last_level -
>>>> first_level + 1)
>>>>     in W.
>>>>
>>>> +  For components that aren't used, the returned values are undefined.
>>>> +
>>>
>>>
>>> Perhaps I'm just not seeing something obvious... but what does this
>>> mean? I'm reading this as "If you don't look at a component of the
>>> return value, then unbeknownst to you, since you're not looking at it,
>>> the value is undefined."
>>
>>
>> Oh. I just got what you were saying. Perhaps phrase this as
>>
>> "For non-existent dimensions, the returned values are undefined"?
>
>
> How about, "For components which don't return a resource dimension, their
> value is undefined." ?

Makes sense to me.

Reviewed-by: Ilia Mirkin <imirkin at alum.mit.edu>