[Mesa-dev] [PATCH 12/14] i965/gen8: Initialize aux_mode to GEN8_SURFACE_AUX_MODE_NONE

Pohjolainen, Topi topi.pohjolainen at intel.com
Fri Jul 18 02:36:45 PDT 2014


On Tue, Jul 15, 2014 at 06:32:20PM -0700, Jordan Justen wrote:
> GEN8_SURFACE_AUX_MODE_NONE is 0, so this is a no-op.
> 
> Yet, this also makes it clear that we can compare aux_mode to the
> other GEN8_SURFACE_AUX_MODE_ values. We will want to compare to
> GEN8_SURFACE_AUX_MODE_HIZ.
> 
> Signed-off-by: Jordan Justen <jordan.l.justen at intel.com>

Patches 7-12 are:

Reviewed-by: Topi Pohjolainen <topi.pohjolainen at intel.com>

> ---
>  src/mesa/drivers/dri/i965/gen8_surface_state.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/mesa/drivers/dri/i965/gen8_surface_state.c b/src/mesa/drivers/dri/i965/gen8_surface_state.c
> index 3d97232..4818fca 100644
> --- a/src/mesa/drivers/dri/i965/gen8_surface_state.c
> +++ b/src/mesa/drivers/dri/i965/gen8_surface_state.c
> @@ -133,7 +133,7 @@ gen8_update_texture_surface(struct gl_context *ctx,
>     struct gl_texture_image *firstImage = tObj->Image[0][tObj->BaseLevel];
>     struct gl_sampler_object *sampler = _mesa_get_samplerobj(ctx, unit);
>     struct intel_miptree_aux_buffer *aux_buf = NULL;
> -   uint32_t aux_mode = 0;
> +   uint32_t aux_mode = GEN8_SURFACE_AUX_MODE_NONE;
>     mesa_format format = intelObj->_Format;
>  
>     if (tObj->Target == GL_TEXTURE_BUFFER) {
> @@ -309,7 +309,7 @@ gen8_update_renderbuffer_surface(struct brw_context *brw,
>     struct intel_renderbuffer *irb = intel_renderbuffer(rb);
>     struct intel_mipmap_tree *mt = irb->mt;
>     struct intel_miptree_aux_buffer *aux_buf = NULL;
> -   uint32_t aux_mode = 0;
> +   uint32_t aux_mode = GEN8_SURFACE_AUX_MODE_NONE;
>     unsigned width = mt->logical_width0;
>     unsigned height = mt->logical_height0;
>     unsigned pitch = mt->pitch;
> -- 
> 2.0.0
> 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list