[Mesa-dev] [Bug 81500] wrong color in flightgear for the c172p if "Atmospheric light scattering" is used

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Sun Jul 20 12:11:22 PDT 2014


--- Comment #22 from Ilia Mirkin <imirkin at alum.mit.edu> ---
(In reply to comment #21)
> (In reply to comment #20)
> > 
> > Just a word of caution -- the fix might have been to a different part of the
> > code, and not to that particular file. You can use bisect again to figure
> > out the change that fixed it, just reverse the meanings of 'good' and 'bad'.
> > A "good" commit would be one that has the issue, and a "bad" commit would be
> > one where the issue is resolved. Then the first "bad" commit will point you
> > at the commit that resolves the problem.
> I did this type of bisect,
> and I managed to find the commit in 10.3.x who solves the bug : it's the
> commit 	1d9f74eda75da05b4d5c7df5fc1e6f5ab8d88322 :
> http://cgit.freedesktop.org/mesa/mesa/commit/
> ?id=1d9f74eda75da05b4d5c7df5fc1e6f5ab8d88322&utm_source=anzwix
> the good news is that if I apply the patch of this commit with 10.2.4 source
> code then the bug is solved,
> Do you think is it safe to push this commit in 10.2 branch of mesa ?
> for me it seems ok but I didn't do the piglit tests

>From what I can see, this commit has nothing to do with any issues introduced
by the originally bad commit... this will require some investigation.



first bad commit: d030a3404ca0fedf365cb0fd41eaad7abc8ff132
commit that "fixes" it on master: 1d9f74eda75da05b4d5c7df5fc1e6f5ab8d88322

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20140720/939f6f80/attachment.html>

More information about the mesa-dev mailing list