[Mesa-dev] [PATCH] glapi: add indexed blend functions (GL 4.0)

[Brian Paul]

On 07/25/2014 01:20 AM, Tapani Pälli wrote:
> This makes some of the UE4 engine demos (Stylized, Mobile Temple)
> render correctly, tested on Intel Haswell machine.
>
> Signed-off-by: Tapani Pälli <tapani.palli at intel.com>
> Acked-by: Anuj Phogat <anuj.phogat at gmail.com>
> Bugzilla: https://urldefense.proofpoint.com/v1/url?u=https://bugs.freedesktop.org/show_bug.cgi?id%3D78716&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r=lGQMzzTgII0I7jefp2FHq7WtZ%2BTLs8wadB%2BiIj9xpBY%3D%0A&m=b4j5RoNNKX6yKywAuOo62OQvfHjv4wjbWFTtgz%2F3k6M%3D%0A&s=d9a2438bbce57ce8145ee2b483eef16a304ce94aa2e9fb74be2e97c5c24bbbff
> ---
>   src/mapi/glapi/gen/GL4x.xml             | 26 ++++++++++++++++++++++++++
>   src/mesa/main/tests/dispatch_sanity.cpp | 10 +++++-----
>   2 files changed, 31 insertions(+), 5 deletions(-)
>
> diff --git a/src/mapi/glapi/gen/GL4x.xml b/src/mapi/glapi/gen/GL4x.xml
> index 8efef0b..848316e 100644
> --- a/src/mapi/glapi/gen/GL4x.xml
> +++ b/src/mapi/glapi/gen/GL4x.xml
> @@ -12,6 +12,32 @@
>     <function name="MinSampleShading" offset="assign">
>       <param name="value" type="GLfloat"/>
>     </function>
> +
> +  <function name="BlendFunci" static_dispatch="false" alias="BlendFunciARB">
> +    <param name="buf" type="GLuint"/>
> +    <param name="sfactor" type="GLenum"/>
> +    <param name="dfactor" type="GLenum"/>
> +  </function>
> +
> +  <function name="BlendFuncSeparatei" static_dispatch="false" alias="BlendFuncSeparateiARB">
> +    <param name="buf" type="GLuint"/>
> +    <param name="sfactorRGB" type="GLenum"/>
> +    <param name="dfactorRGB" type="GLenum"/>
> +    <param name="sfactorAlpha" type="GLenum"/>
> +    <param name="dfactorAlpha" type="GLenum"/>
> +  </function>
> +
> +  <function name="BlendEquationi" static_dispatch="false" alias="BlendEquationiARB">
> +    <param name="buf" type="GLuint"/>
> +    <param name="mode" type="GLenum"/>
> +  </function>
> +
> +  <function name="BlendEquationSeparatei" static_dispatch="false" alias="BlendEquationSeparateiARB" >
> +    <param name="buf" type="GLuint"/>
> +    <param name="modeRGB" type="GLenum"/>
> +    <param name="modeA" type="GLenum"/>
> +  </function>
> +
>   </category>
>
>   <category name="4.3">
> diff --git a/src/mesa/main/tests/dispatch_sanity.cpp b/src/mesa/main/tests/dispatch_sanity.cpp
> index 6c4bdee..5e751f4 100644
> --- a/src/mesa/main/tests/dispatch_sanity.cpp
> +++ b/src/mesa/main/tests/dispatch_sanity.cpp
> @@ -542,11 +542,11 @@ const struct function gl_core_functions_possible[] = {
>      { "glVertexAttribDivisor", 33, -1 },
>
>      /* GL 4.0 */
> -   { "glMinSampleShading", 40, -1 },                    // XXX: Add to xml
> -// { "glBlendEquationi", 40, -1 },                      // XXX: Add to xml
> -// { "glBlendEquationSeparatei", 40, -1 },              // XXX: Add to xml
> -// { "glBlendFunci", 40, -1 },                          // XXX: Add to xml
> -// { "glBlendFuncSeparatei", 40, -1 },                  // XXX: Add to xml
> +   { "glMinSampleShading", 40, -1 },
> +   { "glBlendEquationi", 40, -1 },
> +   { "glBlendEquationSeparatei", 40, -1 },
> +   { "glBlendFunci", 40, -1 },
> +   { "glBlendFuncSeparatei", 40, -1 },
>
>      /* GL 4.3 */
>      { "glIsRenderbuffer", 43, -1 },
>

Looks OK to me.

Reviewed-by: Brian Paul <brianp at vmware.com>