[Mesa-dev] [PATCH] i965: Implement support for ARB_clip_control.

Mathias Fröhlich Mathias.Froehlich at gmx.net
Thu Apr 2 09:37:13 PDT 2015


Hi Kenneth,

On Tuesday, March 31, 2015 14:31:41 Kenneth Graunke wrote:
> Wow, Gen4 even :)  This looks good to me - and using _FrontBit does
> simplify things quite a bit.  Thanks!
Well, it's just that this is the test system that I have found around
here which enables me to get at least some small test coverage :-).

> Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
> 
> I ran some Intel internal tests at this (which barely even function, so
> I don't put a lot of stock in them)...it seems like there might be some
> bad interactions with multisampling.  But I'm not seeing anything
> obviously missing.  Most of the tests look good.

Thanks for the Review!
Given those test results, is there anything I should do or is it ok
to push as is?

Greetings

Mathias
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20150402/b5ce6ae9/attachment.html>


More information about the mesa-dev mailing list