[Mesa-dev] [PATCH] i965: Implement support for ARB_clip_control.

Kenneth Graunke kenneth at whitecape.org
Thu Apr 2 11:09:34 PDT 2015


On Thursday, April 02, 2015 06:37:13 PM Mathias Fröhlich wrote:
> 
> Hi Kenneth,
> 
> On Tuesday, March 31, 2015 14:31:41 Kenneth Graunke wrote:
> > Wow, Gen4 even :)  This looks good to me - and using _FrontBit does
> > simplify things quite a bit.  Thanks!
> Well, it's just that this is the test system that I have found around
> here which enables me to get at least some small test coverage :-).
> 
> > Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
> > 
> > I ran some Intel internal tests at this (which barely even function, so
> > I don't put a lot of stock in them)...it seems like there might be some
> > bad interactions with multisampling.  But I'm not seeing anything
> > obviously missing.  Most of the tests look good.
> 
> Thanks for the Review!
> Given those test results, is there anything I should do or is it ok
> to push as is?
> 
> Greetings
> 
> Mathias

Fine by me - thanks again!

--Ken
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20150402/a28fdb12/attachment.sig>


More information about the mesa-dev mailing list