[Mesa-dev] [PATCH] glsl: make linker error message more informative

Ilia Mirkin imirkin at alum.mit.edu
Wed Aug 12 17:05:44 PDT 2015


Please change those to be %u, all those are GLuint's. With that fixed,

Reviewed-by: Ilia Mirkin <imirkin at alum.mit.edu>

On Wed, Aug 12, 2015 at 3:03 AM, Timothy Arceri <t_arceri at yahoo.com.au> wrote:
> ---
>  src/glsl/linker.cpp | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/src/glsl/linker.cpp b/src/glsl/linker.cpp
> index d7efea5..e18754a 100644
> --- a/src/glsl/linker.cpp
> +++ b/src/glsl/linker.cpp
> @@ -2880,8 +2880,9 @@ check_image_resources(struct gl_context *ctx, struct gl_shader_program *prog)
>
>        if (sh) {
>           if (sh->NumImages > ctx->Const.Program[i].MaxImageUniforms)
> -            linker_error(prog, "Too many %s shader image uniforms\n",
> -                         _mesa_shader_stage_to_string(i));
> +            linker_error(prog, "Too many %s shader image uniforms (%d > %d)\n",
> +                         _mesa_shader_stage_to_string(i), sh->NumImages,
> +                         ctx->Const.Program[i].MaxImageUniforms);
>
>           total_image_units += sh->NumImages;
>
> --
> 2.4.3
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list