[Mesa-dev] [PATCH resend 1/7] i965: Define HW-binding table and resource streamer control opcodes

Kenneth Graunke kenneth at whitecape.org
Tue Jun 2 01:05:26 PDT 2015

On Monday, June 01, 2015 03:14:24 PM Abdiel Janulgue wrote:
> v2: Simplify HW binding table bit definitions and magic constants (Topi)
> v3: Add Broadwell support.
> Cc: kristian.h.kristensen at intel.com
> Cc: topi.pohjolainen at intel.com
> Cc: kenneth at whitecape.org
> Reviewed-by: Topi Pohjolainen <topi.pohjolainen at intel.com>
> Signed-off-by: Abdiel Janulgue <abdiel.janulgue at linux.intel.com>
> ---
>  src/mesa/drivers/dri/i965/brw_defines.h | 30 ++++++++++++++++++++++++++++++
>  src/mesa/drivers/dri/i965/intel_reg.h   |  3 +++
>  2 files changed, 33 insertions(+)

Hi Abdiel,

I've finished reviewing this round of HW binding table patches.  Despite
the number of comments I had, I think most of them should be pretty
straightforward changes.  I actually think that these patches look quite
reasonable, and I expect we can land them soon.

I think you've demonstrated that gather constants are a big win, and
we'll need hardware binding tables to make that happen.  So it makes
sense to land this infrastructure in preparation for those.  I
appreciate how unintrusive these changes are.  You've done a nice job
of making the transition simple, and the patch series was easy to read

Thanks for your hard work in this area!  I'll try to look at the gather
constant patches soon as well.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20150602/3adaa8dc/attachment.sig>

More information about the mesa-dev mailing list