[Mesa-dev] [PATCH resend 1/7] i965: Define HW-binding table and resource streamer control opcodes

[Abdiel Janulgue]

On 06/02/2015 11:05 AM, Kenneth Graunke wrote:
> On Monday, June 01, 2015 03:14:24 PM Abdiel Janulgue wrote:
>> v2: Simplify HW binding table bit definitions and magic constants (Topi)
>> v3: Add Broadwell support.
>>
>> Cc: kristian.h.kristensen at intel.com
>> Cc: topi.pohjolainen at intel.com
>> Cc: kenneth at whitecape.org
>> Reviewed-by: Topi Pohjolainen <topi.pohjolainen at intel.com>
>> Signed-off-by: Abdiel Janulgue <abdiel.janulgue at linux.intel.com>
>> ---
>>  src/mesa/drivers/dri/i965/brw_defines.h | 30 ++++++++++++++++++++++++++++++
>>  src/mesa/drivers/dri/i965/intel_reg.h   |  3 +++
>>  2 files changed, 33 insertions(+)
> 
> Hi Abdiel,
> 
> I've finished reviewing this round of HW binding table patches.  Despite
> the number of comments I had, I think most of them should be pretty
> straightforward changes.  I actually think that these patches look quite
> reasonable, and I expect we can land them soon.
> 
> I think you've demonstrated that gather constants are a big win, and
> we'll need hardware binding tables to make that happen.  So it makes
> sense to land this infrastructure in preparation for those.  I
> appreciate how unintrusive these changes are.  You've done a nice job
> of making the transition simple, and the patch series was easy to read
> through.
> 
> Thanks for your hard work in this area!  I'll try to look at the gather
> constant patches soon as well.

Thanks for the review Ken! I appreciate it a lot! I'll try to
incorporate your feedback in the v2.

-Abdiel