[Mesa-dev] [PATCH 3/4] r600/sb_sched: fix what appears to be a typo in a condition

[Glenn Kennard]

On Fri, 05 Jun 2015 19:39:31 +0200, Marek Olšák <maraeo at gmail.com> wrote:

> I'd like somebody who knows r600/sb to review this. Glenn, can I
> bother you please? :)
>
> Marek
>
> On Fri, Jun 5, 2015 at 2:31 PM, Martin Peres
> <martin.peres at linux.intel.com> wrote:
>> Signed-off-by: Martin Peres <martin.peres at linux.intel.com>
>> ---
>>  src/gallium/drivers/r600/sb/sb_sched.cpp | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/src/gallium/drivers/r600/sb/sb_sched.cpp  
>> b/src/gallium/drivers/r600/sb/sb_sched.cpp
>> index 2e38a62..6268078 100644
>> --- a/src/gallium/drivers/r600/sb/sb_sched.cpp
>> +++ b/src/gallium/drivers/r600/sb/sb_sched.cpp
>> @@ -489,7 +489,7 @@ bool alu_group_tracker::try_reserve(alu_node* n) {
>>
>>         n->bc.bank_swizzle = 0;
>>
>> -       if (!trans & fbs)
>> +       if (!trans && fbs)
>>                 n->bc.bank_swizzle = VEC_210;
>>
>>         if (gpr.try_reserve(n)) {
>> --
>> 2.4.2
>>
>> _______________________________________________
>> mesa-dev mailing list
>> mesa-dev at lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/mesa-dev

In theory this changes behavior, but the current implementation of the  
function that sets fbs - forced_bank_swizzle() only returns two values,  
VEC_012=0 or VEC_210=5, so the bit value tested coincides with the logical  
&& operation, so if using logical and instead silences gcc 5 irritable  
warning syndrome, it can get a

Reviewed-by: Glenn Kennard <glenn.kennard at gmail.com>