[Mesa-dev] [PATCH 3/3] i965: Export format comparison for blitting between miptrees

Jason Ekstrand jason at jlekstrand.net
Tue Jun 9 14:26:36 PDT 2015


On Tue, Jun 9, 2015 at 2:24 PM, Alexander Monakov <amonakov at gmail.com> wrote:
> Hello,
>
> Unfortunately, this patch breaks things further, because...
>
> On Fri, Jun 5, 2015 at 5:14 PM, Chris Wilson <chris at chris-wilson.co.uk> wrote:
>> @@ -76,8 +77,14 @@ do_blit_drawpixels(struct gl_context * ctx,
>>     struct gl_renderbuffer *rb = ctx->DrawBuffer->_ColorDrawBuffers[0];
>>     struct intel_renderbuffer *irb = intel_renderbuffer(rb);
>>
>> -   if (!_mesa_format_matches_format_and_type(irb->mt->format, format, type,
>> -                                             false)) {
>> +   mesa_format src_format = _mesa_format_from_format_and_type(format, type);
>
> _mesa_format_from_format_and_type may return either mesa_format or
> mesa_array_format, which needs further decoding since here we do need
> a mesa_format.  The attached patch unbreaks this — please apply it for
> me if reviewed.

In the future, please use git-send-email or similar to send patches so
that they show up directly in the e-mail text instead of as
attachments.  In the moment,

Reviewed-by: Jason Ekstrand <jason.ekstrand at intel.com>


More information about the mesa-dev mailing list