[Mesa-dev] [PATCH v2 0/6] Continu enabling Open Gl ES 3.1

[Tapani Pälli]

On 06/11/2015 03:08 PM, Tapani Pälli wrote:
>
>
> On 06/11/2015 03:01 PM, Tapani Pälli wrote:
>> Patches 1,2,4,5
>>
>> Reviewed-by: Tapani Pälli <tapani.palli at intel.com>
>
> Just to add the r-b is for v3 that you sent separately for:
> "mesa/es3.1: enable ARB_shader_atomic_counters for GLES 3.1"
>
> (not the one in this particular series)
>
>> For 3 and 6 (multisample + explicit_uniform_locaion) you need to move
>> the enums in to the following array:
>>
>> { "apis": ["GL", "GL_CORE", "GLES3"], "params": [

Urgh sorry ... now when I started to double-check things I've realized 
this actually applies to all of your patches! So forget about my earlier 
review.

This is quite hard to spot just by looking at the diffs (or at Piglit 
results as this depends on if there happens to exist a test that is run 
in compatibility profile and query some enum) but yep, all of these 
extensions are available also for compatibility profile, so you cannot 
have them in a core only section.

(GL_ARB_draw_indirect is exposed for core only by Mesa so that is still 
fine.)

>>
>>
>> On 05/07/2015 10:57 AM, Marta Lofstedt wrote:
>>> Changes to my previous patch-set accoring to comments
>>> from Tapani Palli. This will only expose the enums
>>> for the respective extensions to gles 3.1 and GL Core.
>>>
>>> Marta Lofstedt (6):
>>>    mesa/es3.1: enable GL_ARB_shader_image_load_store for gles3.1
>>>    mesa/es3.1: enable ARB_shader_atomic_counters for GLES 3.1
>>>    mesa/es3.1: enable GL_ARB_texture_multisample for GLES 3.1
>>>    mesa/es3.1: enable GL_ARB_texture_gather for GLES 3.1
>>>    mesa/es3.1: enable GL_ARB_compute_shader for GLES 3.1
>>>    mesa/es3.1: enable GL_ARB_explicit_uniform_location for GLES 3.1
>>>
>>>   src/mesa/main/get.c              | 36 ++++++++++++++++
>>>   src/mesa/main/get_hash_params.py | 88
>>> ++++++++++++++++++++--------------------
>>>   2 files changed, 80 insertions(+), 44 deletions(-)
>>>
>> _______________________________________________
>> mesa-dev mailing list
>> mesa-dev at lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev