[Mesa-dev] [PATCH v2 16/82] mesa: Implement _mesa_DeleteBuffers for target GL_SHADER_STORAGE_BUFFER

Samuel Iglesias Gonsálvez siglesias at igalia.com
Wed Jun 17 22:20:09 PDT 2015



On 17/06/15 20:44, Jordan Justen wrote:
> On 2015-06-03 00:01:06, Iago Toral Quiroga wrote:
>> ---
>>  src/mesa/main/bufferobj.c | 11 +++++++++++
>>  1 file changed, 11 insertions(+)
>>
>> diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c
>> index a528787..0e762df 100644
>> --- a/src/mesa/main/bufferobj.c
>> +++ b/src/mesa/main/bufferobj.c
>> @@ -1264,6 +1264,17 @@ _mesa_DeleteBuffers(GLsizei n, const GLuint *ids)
>>              _mesa_BindBuffer( GL_UNIFORM_BUFFER, 0 );
>>           }
>>  
>> +         /* unbind SSBO binding points */
>> +         for (j = 0; j < ctx->Const.MaxShaderStorageBufferBindings; j++) {
>> +            if (ctx->ShaderStorageBufferBindings[j].BufferObject == bufObj) {
>> +               _mesa_BindBufferBase( GL_SHADER_STORAGE_BUFFER, j, 0 );
>> +            }
>> +         }
>> +
>> +         if (ctx->ShaderStorageBuffer == bufObj) {
>> +            _mesa_BindBuffer( GL_SHADER_STORAGE_BUFFER, 0 );
>> +         }
> 
> Can you remove the extra spaces after '(' and before ')'?
> 

Sure, I will remove them. They were added as it was the convention for
similar code in this file.

> Reviewed-by: Jordan Justen <jordan.l.justen at intel.com>
> 

Thanks,

Sam

>> +
>>           /* unbind Atomci Buffer binding points */
>>           for (j = 0; j < ctx->Const.MaxAtomicBufferBindings; j++) {
>>              if (ctx->AtomicBufferBindings[j].BufferObject == bufObj) {
>> -- 
>> 1.9.1
>>
>> _______________________________________________
>> mesa-dev mailing list
>> mesa-dev at lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
> 


More information about the mesa-dev mailing list