[Mesa-dev] [PATCH 1/5] darwin: Suppress type conversion warnings for GLhandleARB

[Emil Velikov]

On 18 June 2015 at 06:53, Julien Isorce <julien.isorce at gmail.com> wrote:
> From: Jon TURNEY <jon.turney at dronecode.org.uk>
>
> On darwin, GLhandleARB is defined as a void *, not the unsigned int it is on
> linux.
>
> For the moment, apply a cast to supress the warning
>
> Possibly this is safe, as for the mesa software renderer the shader program
> handle is not a real pointer, but a integer handle
>
> Probably this is not the right thing to do, and we should pay closer attention
> to how the GLhandlerARB type is used.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=66346
Imho one's goal should not be to find the quickest solution to shut
warnings up, but to understand them.
As mentioned by Jeremy Huddleston in comment 11, this approach only
masks the issue.

There was a lengthy discussion(s) on the topic a while back and one of
the objections on the proposed fixes (from Ian iirc) was that it will
break the libglapi ABI. As Jeremy did not see that as a concern
perhaps we can revive them and make sure that the ABI change does not
happen in the non-Mac world.

-Emil