[Mesa-dev] [PATCH 1/5] darwin: Suppress type conversion warnings for GLhandleARB

[Julien Isorce]

Hi Emil,

Do you mean adding the cast only if __APPLE__ is defined ?

Actually when reading comment #2 we should get the build error for
src/mesa/main/uniform_query.cpp
too but it is not the case anymore. So with git blame I can see that the
build error has been fixed by commit d96ed5c0 for the file uniform_query.cpp
only.

But can we apply the same for _mesa_BindAttribLocation in shader_query.cpp
? I can see in the spec that non-ARB version of glBindAttribLocation 's
first param is GLuint
https://www.opengl.org/sdk/docs/man3/xhtml/glBindAttribLocation.xml
(gles2:
https://www.khronos.org/opengles/sdk/docs/man/xhtml/glBindAttribLocation.xml
)

What is the purpose of src/mapi/glapi/gen/ARB_robustness.xml ?

Thx
Julien

On 18 June 2015 at 19:16, Emil Velikov <emil.l.velikov at gmail.com> wrote:

> On 18 June 2015 at 06:53, Julien Isorce <julien.isorce at gmail.com> wrote:
> > From: Jon TURNEY <jon.turney at dronecode.org.uk>
> >
> > On darwin, GLhandleARB is defined as a void *, not the unsigned int it
> is on
> > linux.
> >
> > For the moment, apply a cast to supress the warning
> >
> > Possibly this is safe, as for the mesa software renderer the shader
> program
> > handle is not a real pointer, but a integer handle
> >
> > Probably this is not the right thing to do, and we should pay closer
> attention
> > to how the GLhandlerARB type is used.
> >
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=66346
> Imho one's goal should not be to find the quickest solution to shut
> warnings up, but to understand them.
> As mentioned by Jeremy Huddleston in comment 11, this approach only
> masks the issue.
>
> There was a lengthy discussion(s) on the topic a while back and one of
> the objections on the proposed fixes (from Ian iirc) was that it will
> break the libglapi ABI. As Jeremy did not see that as a concern
> perhaps we can revive them and make sure that the ABI change does not
> happen in the non-Mac world.
>
> -Emil
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20150618/4598e424/attachment.html>