[Mesa-dev] [PATCH v2 4/7] glsl: No need to lock in _mesa_glsl_release_types

[Erik Faye-Lund]

On Fri, Jun 26, 2015 at 12:29 AM, Matt Turner <mattst88 at gmail.com> wrote:
> On Thu, Jun 25, 2015 at 2:05 PM, Erik Faye-Lund <kusmabite at gmail.com> wrote:
>> This function only gets called while mesa is unloading, so there's
>> no potential of racing or multiple calls at the same time. So let's
>> just get rid of the locking.
>>
>> Signed-off-by: Erik Faye-Lund <kusmabite at gmail.com>
>> ---
>>  src/glsl/glsl_types.cpp | 8 ++++----
>>  1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/src/glsl/glsl_types.cpp b/src/glsl/glsl_types.cpp
>> index f675e90..dbe2382 100644
>> --- a/src/glsl/glsl_types.cpp
>> +++ b/src/glsl/glsl_types.cpp
>> @@ -324,8 +324,10 @@ const glsl_type *glsl_type::get_scalar_type() const
>>  void
>>  _mesa_glsl_release_types(void)
>>  {
>> -   mtx_lock(&glsl_type::mutex);
>> -
>> +   /* should only be called during atexit (either when unloading shared
>
> Let's capitalize "should"
>
>> +    * object, or if process terminates), so no mutex-locking should be
>> +    * nessecary.
>
> typo: necessary

Thanks, fixed.