[Mesa-dev] [Bug 91106] glx: make check fails to build on osx

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=91106

--- Comment #3 from Jon TURNEY <jon.turney at dronecode.org.uk> ---
(In reply to Emil Velikov from comment #1) 
> +#if defined(GLX_USE_APPLEGL)
> +#define _ATTRIBUTE_WEAK __attribute__((weak))
> +#else
> +#define _ATTRIBUTE_WEAK
> +#endif
> +
> (If we end up keeping this) Can we avoid redefining it X times ? Ian (the
> original author of these tests) should know the details as to why/how we
> don't end up with duplicated/conflicting symbols.

These really are duplicates that the test harness provides to override the
real versions.

Unfortunately, ld on OSX doesn't behave that way, and the option
-multiply_defined suppress seems to be obsolete.

I'm not very keen on scattering __attribute__(weak) around to fix this, but I
guess the only other approach is to split those symbols out into a separate
object, which is linked with to produce libglx.a, but not into a convenience
library which is used by the tests.

> +	$(top_builddir)/src/mapi/glapi/libglapi.la \
> Which symbols are missing if we omit this ? Noone else seems to need it.

glapi_create_table_from_handle, which only exists on APPLE, if memory serves.

But linking with glapi and shared-glapi doesn't seem right, so I think this is
a sign that something else is wrong.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20150627/b986946a/attachment-0001.html>