[Mesa-dev] [PATCH] mesa: remove unnecessary checks in _mesa_readpixels_needs_slow_path

Iago Toral itoral at igalia.com
Sun Jun 28 23:24:54 PDT 2015


On Mon, 2015-06-29 at 15:21 +0900, Michel Dänzer wrote:
> On 25.06.2015 21:42, Marek Olšák wrote:
> > Gallium should be alright. We'll let you know if we find a regression,
> > but I don't think there will be any.
> 
> Famous last words. :) This change broke the piglit test
> spec at ext_texture_integer@fbo_integer_readpixels_sint_uint for me with
> the radeonsi driver:
> 
> fbo-integer-readpixels-sint-uint: glClear failed
>   Texture format = GL_RGBA32I_EXT
>   Expected 300000005, 0, 6, 5
>   Found 300000005, 4294967289, 6, 5

Ok :), thanks for reporting, I'll write a patch to move these checks to 
st_cb_readpixels.c in that case.

Iago



More information about the mesa-dev mailing list