[Mesa-dev] [PATCH 00/78] i965: A new vec4 backend based on NIR

Jason Ekstrand jason at jlekstrand.net
Tue Jun 30 09:29:12 PDT 2015

Another general comment:  It seems like you may have copied+pasted a
bit much when it comes to handling arrays in the backend.  In the FS
backend, we have to multiply lots of stuff by reg->num_components
because we need to scalarize it.  In the vec4 backend, we don't need
to do this because reg->num_components is never more than 4 so any
array is just an array of regular vec4 registers with one register per
array slot.  The net result of this is that you allocate way too many
registers.  This may be part of your spilling problems.

I'm going to continue to point this out as I go, but it's systemic
enough that you might as well start working on fixing it before I get
done reviewing.

On Mon, Jun 29, 2015 at 4:56 PM, Eduardo Lima Mitev <elima at igalia.com> wrote:
> On 06/30/2015 01:49 AM, Jason Ekstrand wrote:
>> As a general comment, please remove the Bugzilla tags from the
>> commits.  This is a new feature, not a bugfix.  If you want to leave a
>> reference to the bug, pick a commit and put it there but it doesn't
>> need to be in all of them.
>> --Jason
> Ok, that's only my fault :). I inserted that line in every commit of the
> series.
> We will be removing the tag from every patch as we submit new versions.
> Thanks a lot for the reviews!
> Eduardo

More information about the mesa-dev mailing list