[Mesa-dev] [PATCH 00/78] i965: A new vec4 backend based on NIR
jason at jlekstrand.net
Tue Jun 30 16:46:47 PDT 2015
Ok, I think I've looked through more-or-less the whole thing. The
only thing I haven't looked at is the texturing stuff but I think I'd
like (and Ken agrees) to just refactor the old code to split the guts
into something re-usable and make a much shorter NIR function.
Most of it really looks pretty good but I've left a trail of comments.
I'm not sure that I really want a full re-send once the changes are
made. If it makes sense, it may be better to do the fixes as a few
patches on top of the series. If that doesn't make sense, just do a
re-send; it'll be fine.
On Tue, Jun 30, 2015 at 9:29 AM, Jason Ekstrand <jason at jlekstrand.net> wrote:
> Another general comment: It seems like you may have copied+pasted a
> bit much when it comes to handling arrays in the backend. In the FS
> backend, we have to multiply lots of stuff by reg->num_components
> because we need to scalarize it. In the vec4 backend, we don't need
> to do this because reg->num_components is never more than 4 so any
> array is just an array of regular vec4 registers with one register per
> array slot. The net result of this is that you allocate way too many
> registers. This may be part of your spilling problems.
> I'm going to continue to point this out as I go, but it's systemic
> enough that you might as well start working on fixing it before I get
> done reviewing.
> On Mon, Jun 29, 2015 at 4:56 PM, Eduardo Lima Mitev <elima at igalia.com> wrote:
>> On 06/30/2015 01:49 AM, Jason Ekstrand wrote:
>>> As a general comment, please remove the Bugzilla tags from the
>>> commits. This is a new feature, not a bugfix. If you want to leave a
>>> reference to the bug, pick a commit and put it there but it doesn't
>>> need to be in all of them.
>> Ok, that's only my fault :). I inserted that line in every commit of the
>> We will be removing the tag from every patch as we submit new versions.
>> Thanks a lot for the reviews!
More information about the mesa-dev