[Mesa-dev] [PATCH V6 12/27] glsl: avoid hitting assert for arrays of arrays

Ian Romanick idr at freedesktop.org
Tue Oct 6 13:11:32 PDT 2015


When this lands we should probably also submit a bug report.  It is
likely to be forgotten otherwise.  This patch is

Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>

On 09/28/2015 07:42 PM, Timothy Arceri wrote:
> Also add TODO comment about adding proper support
> 
> Signed-off-by: Timothy Arceri <t_arceri at yahoo.com.au>
> ---
>  src/glsl/ir_set_program_inouts.cpp | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/src/glsl/ir_set_program_inouts.cpp b/src/glsl/ir_set_program_inouts.cpp
> index b7a0f6e..d7c29b0 100644
> --- a/src/glsl/ir_set_program_inouts.cpp
> +++ b/src/glsl/ir_set_program_inouts.cpp
> @@ -242,6 +242,12 @@ ir_set_program_inouts_visitor::try_mark_partial_variable(ir_variable *var,
>        type = type->fields.array;
>     }
>  
> +   /* TODO: implement proper arrays of arrays support
> +    * for now let the caller mark whole variable as used.
> +    */
> +   if (type->is_array() && type->fields.array->is_array())
> +      return false;
> +
>     /* The code below only handles:
>      *
>      * - Indexing into matrices
> 



More information about the mesa-dev mailing list