[Mesa-dev] [PATCH] mesa: Correctly handle GL_BGRA_EXT in ES3 format_and_type checks

[Mark Janes]

No regressions were indicated by this patch.  However, the initial
regression did not trigger any test failures, either.

It is unacceptable for such an obvious regression to pass Mesa's
automated test suites.  I re-opened the bug, pending the creation of
suitable tests.

-Mark

Emil Velikov <emil.l.velikov at gmail.com> writes:

> On 07/10/15 23:58, Jason Ekstrand wrote:
>> The EXT_texture_format_BGRA8888 extension (which mesa supports
>> unconditionally) adds a new format and internal format called GL_BGRA_EXT.
>> Previously, this was not really handled at all in
>> _mesa_ex3_error_check_format_and_type.  When the checks were tightened in
>> commit f15a7f3c, we accidentally tightened things too far and GL_BGRA_EXT
>> would always cause an error to be thrown.
>> 
>> There were two primary issues here.  First, is that
>> _mesa_es3_effective_internal_format_for_format_and_type didn't handle the
>> GL_BGRA_EXT format.  Second is that it blindly uses _mesa_base_tex_format
>> which returns GL_RGBA for GL_BGRA_EXT.  This commit fixes both of these
>> issues as well as adds explicit checks that GL_BGRA_EXT is only ever used
>> with GL_BGRA_EXT and GL_UNSIGNED_BYTE.
>> 
>> Signed-off-by: Jason Ekstrand <jason.ekstrand at intel.com>
>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=92265
>> Cc: Eduardo Lima Mitev <elima at igalia.com>
> Thanks for the fix Jason.
>
> Mark, can you give this patch a spin on jenkins ? It's in master so
> chances are that it's already been tested :)
>
> Cheers,
> Emil