[Mesa-dev] [PATCH 02/10] vbo: remove unneeded ctx parameter for merge_prims()

[Brian Paul]

On 10/17/2015 08:35 AM, Marek Olšák wrote:
> Patches 2-9:
>
> Reviewed-by: Marek Olšák <marek.olsak at amd.com>
>
> I can't comment on 10 without some additional research. Maybe someone
> else will review it.

Thanks for the reviews.  I think one of my coworkers can take a look.

I tested with a modified piglit lineloop test (patch posted to piglit 
list), and a proprietary app that makes heavy use of display lists. 
Conform only tests short dlist loops.

-Brian


>
> Marek
>
> On Fri, Oct 16, 2015 at 11:25 PM, Brian Paul <brianp at vmware.com> wrote:
>> ---
>>   src/mesa/vbo/vbo_save_api.c | 5 ++---
>>   1 file changed, 2 insertions(+), 3 deletions(-)
>>
>> diff --git a/src/mesa/vbo/vbo_save_api.c b/src/mesa/vbo/vbo_save_api.c
>> index fdc677f..6688ba0 100644
>> --- a/src/mesa/vbo/vbo_save_api.c
>> +++ b/src/mesa/vbo/vbo_save_api.c
>> @@ -330,8 +330,7 @@ _save_reset_counters(struct gl_context *ctx)
>>    * previous prim.
>>    */
>>   static void
>> -merge_prims(struct gl_context *ctx,
>> -            struct _mesa_prim *prim_list,
>> +merge_prims(struct _mesa_prim *prim_list,
>>               GLuint *prim_count)
>>   {
>>      GLuint i;
>> @@ -442,7 +441,7 @@ _save_compile_vertex_list(struct gl_context *ctx)
>>       */
>>      save->copied.nr = _save_copy_vertices(ctx, node, save->buffer);
>>
>> -   merge_prims(ctx, node->prim, &node->prim_count);
>> +   merge_prims(node->prim, &node->prim_count);
>>
>>      /* Deal with GL_COMPILE_AND_EXECUTE:
>>       */
>> --
>> 1.9.1
>>
>> _______________________________________________
>> mesa-dev mailing list
>> mesa-dev at lists.freedesktop.org
>> https://urldefense.proofpoint.com/v2/url?u=http-3A__lists.freedesktop.org_mailman_listinfo_mesa-2Ddev&d=BQIFaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=T0t4QG7chq2ZwJo6wilkFznRSFy-8uDKartPGbomVj8&m=ipNW-t68AwDF2z05Yqk-8Az2D24zuXeCdW1gWb2EPx0&s=qoqFittQWGv4uUe8kssry3lf1kfGiwYpQNON0Vod-9A&e=
>