[Mesa-dev] [PATCH 37/40] targets/nine: add note about fd owndership

Emil Velikov emil.l.velikov at gmail.com
Sat Oct 17 15:58:11 PDT 2015


Cc: Axel Davy <axel.davy at ens.fr>
Signed-off-by: Emil Velikov <emil.l.velikov at gmail.com>
---
 src/gallium/targets/d3dadapter9/Makefile.am | 1 +
 src/gallium/targets/d3dadapter9/drm.c       | 2 ++
 2 files changed, 3 insertions(+)

diff --git a/src/gallium/targets/d3dadapter9/Makefile.am b/src/gallium/targets/d3dadapter9/Makefile.am
index ca49a87..d1d9829 100644
--- a/src/gallium/targets/d3dadapter9/Makefile.am
+++ b/src/gallium/targets/d3dadapter9/Makefile.am
@@ -99,6 +99,7 @@ if HAVE_GALLIUM_STATIC_TARGETS
 d3dadapter9_la_CPPFLAGS = $(AM_CPPFLAGS) $(TARGET_CPPFLAGS)
 d3dadapter9_la_LIBADD += \
 	$(top_builddir)/src/gallium/auxiliary/pipe-loader/libpipe_loader_static.la \
+	$(GALLIUM_PIPE_LOADER_WINSYS_LIBS) \
 	$(TARGET_LIB_DEPS) \
 	$(TARGET_RADEON_WINSYS) $(TARGET_RADEON_COMMON)
 
diff --git a/src/gallium/targets/d3dadapter9/drm.c b/src/gallium/targets/d3dadapter9/drm.c
index c890191..dc040dc 100644
--- a/src/gallium/targets/d3dadapter9/drm.c
+++ b/src/gallium/targets/d3dadapter9/drm.c
@@ -216,6 +216,8 @@ drm_create_adapter( int fd,
 
     ctx->base.destroy = drm_destroy;
 
+    /* XXX: Is the owner responsible for FD owndership or are we ?
+     * In the former we're screwing things hard here */
     fd = loader_get_user_preferred_fd(fd, &different_device);
     ctx->fd = fd;
     ctx->base.linear_framebuffer = !!different_device;
-- 
2.6.1



More information about the mesa-dev mailing list