[Mesa-dev] [PATCH 37/40] targets/nine: add note about fd owndership

[Emil Velikov]

On 17 October 2015 at 23:58, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> Cc: Axel Davy <axel.davy at ens.fr>
> Signed-off-by: Emil Velikov <emil.l.velikov at gmail.com>
> ---
>  src/gallium/targets/d3dadapter9/Makefile.am | 1 +
>  src/gallium/targets/d3dadapter9/drm.c       | 2 ++
>  2 files changed, 3 insertions(+)
>
> diff --git a/src/gallium/targets/d3dadapter9/Makefile.am b/src/gallium/targets/d3dadapter9/Makefile.am
> index ca49a87..d1d9829 100644
> --- a/src/gallium/targets/d3dadapter9/Makefile.am
> +++ b/src/gallium/targets/d3dadapter9/Makefile.am
> @@ -99,6 +99,7 @@ if HAVE_GALLIUM_STATIC_TARGETS
>  d3dadapter9_la_CPPFLAGS = $(AM_CPPFLAGS) $(TARGET_CPPFLAGS)
>  d3dadapter9_la_LIBADD += \
>         $(top_builddir)/src/gallium/auxiliary/pipe-loader/libpipe_loader_static.la \
> +       $(GALLIUM_PIPE_LOADER_WINSYS_LIBS) \
Should be part of patch 32/40.

>         $(TARGET_LIB_DEPS) \
>         $(TARGET_RADEON_WINSYS) $(TARGET_RADEON_COMMON)
>
> diff --git a/src/gallium/targets/d3dadapter9/drm.c b/src/gallium/targets/d3dadapter9/drm.c
> index c890191..dc040dc 100644
> --- a/src/gallium/targets/d3dadapter9/drm.c
> +++ b/src/gallium/targets/d3dadapter9/drm.c
> @@ -216,6 +216,8 @@ drm_create_adapter( int fd,
>
>      ctx->base.destroy = drm_destroy;
>
> +    /* XXX: Is the owner responsible for FD owndership or are we ?
> +     * In the former we're screwing things hard here */
This will be updated to "Although the fd is provided from external
source, mesa/nine takes ownership of it." based on input from Axel.

-Emil