[Mesa-dev] [PATCH] radeonsi: add support for ARB_texture_view

[Michel Dänzer]

On 17.10.2015 22:09, Marek Olšák wrote:
> From: Marek Olšák <marek.olsak at amd.com>
> 
> All tests pass. We don't need to do much - just set CUBE if the view
> target is CUBE or CUBE_ARRAY, otherwise set the resource target.
> 
> The reason this is so simple can be that texture instructions
> have a greater effect on the target than the sampler view.

I think you meant to swap "is" and "can be": "The reason this can be so
simple is that texture instructions have a greater effect on the target
than the sampler view."

BTW, is that statement really accurate? Isn't it rather because the
format and mip level clamping was already handled via the sampler view
before?


Anyway, if you fix at least the switcheroo above,

Reviewed-by: Michel Dänzer <michel.daenzer at amd.com>


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer