[Mesa-dev] [PATCH] radeonsi: add support for ARB_texture_view

[Marek Olšák]

On Tue, Oct 20, 2015 at 9:42 AM, Michel Dänzer <michel at daenzer.net> wrote:
> On 17.10.2015 22:09, Marek Olšák wrote:
>> From: Marek Olšák <marek.olsak at amd.com>
>>
>> All tests pass. We don't need to do much - just set CUBE if the view
>> target is CUBE or CUBE_ARRAY, otherwise set the resource target.
>>
>> The reason this is so simple can be that texture instructions
>> have a greater effect on the target than the sampler view.
>
> I think you meant to swap "is" and "can be": "The reason this can be so
> simple is that texture instructions have a greater effect on the target
> than the sampler view."
>
> BTW, is that statement really accurate? Isn't it rather because the
> format and mip level clamping was already handled via the sampler view
> before?

I didn't consider the format and clamping to be anything new here.

The only thing that is new with ARB_texture_view is that the texture
target can be overriden by sampler views. The thing is the hardware
doesn't care much :) setting the correct target in the shader already
had the desired effect for all types except Cube.

Marek