[Mesa-dev] [PATCH 1/7] nir/info: Add more information about geometry shaders

Kenneth Graunke kenneth at whitecape.org
Tue Oct 20 23:28:38 PDT 2015


On Tuesday, October 20, 2015 06:14:23 PM Jason Ekstrand wrote:
> I have no idea why, but gmail and git-send-email aren't getting along
> for me.  The entire series (including patches 6 and 7) can be found
> here:
> 
> http://cgit.freedesktop.org/~jekstrand/mesa/log/?h=wip/i965-gs-cleanup
> 
> --Jason

Comments on patch 7:

You've switched prog_data.include_primitive_id, prog_data.invocations,
and UsesEndPrimitive over to use nir_shader_info rather than gl_program.
This should be done separately from mass code motion, because nobody
wants to bisect that.  (Doing it in patch 5 would make sense...)

With that fixed, the series is:
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20151020/72e1860e/attachment.sig>


More information about the mesa-dev mailing list