[Mesa-dev] [PATCH] st/mesa: don't load state parameters if there are none

[Brian Paul]

On 10/22/2015 05:02 PM, Marek Olšák wrote:
> From: Marek Olšák <marek.olsak at amd.com>
>
> Out of 7063 shaders from my shader-db:
> - 6564 (93%) shaders don't have any state parameters.
> - 347 (5%) shaders have 1 state parameter for WPOS lowering.
> - The remaining 2% have more state parameters, usually matrices.
> ---
>   src/mesa/state_tracker/st_atom_constbuf.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/src/mesa/state_tracker/st_atom_constbuf.c b/src/mesa/state_tracker/st_atom_constbuf.c
> index acaa85d..20f8b3d 100644
> --- a/src/mesa/state_tracker/st_atom_constbuf.c
> +++ b/src/mesa/state_tracker/st_atom_constbuf.c
> @@ -73,7 +73,8 @@ void st_upload_constants( struct st_context *st,
>          * the parameters list are explicitly set by the user with glUniform,
>          * glProgramParameter(), etc.
>          */
> -      _mesa_load_state_parameters(st->ctx, params);
> +      if (params->StateFlags)
> +         _mesa_load_state_parameters(st->ctx, params);
>
>         /* We always need to get a new buffer, to keep the drivers simple and
>          * avoid gratuitous rendering synchronization.
>

Reviewed-by: Brian Paul <brianp at vmware.com>