[Mesa-dev] [PATCH] isl: move -lm at the end of tests_ldadd

Jason Ekstrand jason at jlekstrand.net
Wed Apr 27 18:08:39 UTC 2016


fine by me

Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>

On Wed, Apr 27, 2016 at 11:00 AM, Alejandro PiƱeiro <apinheiro at igalia.com>
wrote:

> The test was failing to build with "undefined reference to `roundf'"
> errors,
> so Make check on mesa was failing.
> ---
>
> The previouos change on the same Makefile.am had the same intention (fixing
> make check using -lm), so I guess that the problem is on my environment.
> Having
> said so, I checked on the rest of the Makefile.am of the project, and they
> place
> the -lm at the end, or at least after the mesa .la
>
>  src/intel/isl/Makefile.am | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/intel/isl/Makefile.am b/src/intel/isl/Makefile.am
> index 806934e..1427e7b 100644
> --- a/src/intel/isl/Makefile.am
> +++ b/src/intel/isl/Makefile.am
> @@ -110,9 +110,9 @@ check_PROGRAMS = $(TESTS)
>
>  # Link tests to lib965_compiler.la for brw_get_device_info().
>  tests_ldadd =                                          \
> -       -lm                                             \
>         libisl.la                                       \
> -       $(top_builddir)/src/mesa/drivers/dri/i965/libi965_compiler.la
> +       $(top_builddir)/src/mesa/drivers/dri/i965/libi965_compiler.la \
> +       -lm
>
>  tests_isl_surf_get_image_offset_test_SOURCES =         \
>         tests/isl_surf_get_image_offset_test.c
> --
> 2.5.0
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20160427/b26c629d/attachment.html>


More information about the mesa-dev mailing list