[Mesa-dev] [PATCH 1/5] glsl/types: disallow implicit conversions before GLSL 1.20

[Andres Gomez]

On Thu, 2016-08-04 at 08:53 +1000, Timothy Arceri wrote:
> On Wed, 2016-08-03 at 23:51 +0300, Andres Gomez wrote:
> > Implicit conversions were added in the GLSL 1.20 spec version.
> > 
> > Signed-off-by: Andres Gomez <agomez at igalia.com>
> > ---
> >  src/compiler/glsl_types.cpp | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/src/compiler/glsl_types.cpp
> > b/src/compiler/glsl_types.cpp
> > index 8a06695..24aec25 100644
> > --- a/src/compiler/glsl_types.cpp
> > +++ b/src/compiler/glsl_types.cpp
> > @@ -1384,6 +1384,10 @@ glsl_type::can_implicitly_convert_to(const
> > glsl_type *desired,
> >     if (this == desired)
> >        return true;
> >  
> > +   /* Prior to GLSL 1.20, there are no implicit conversions */
> > +   if (state && !state->is_version(120, 0))
> > +      return false;
> > +
> 
> I thought you were going to update this one?
> 
> https://lists.freedesktop.org/archives/mesa-dev/2016-August/124873.html

Argh!

Sorry about that ☹

-- 

Br,

Andres