[Mesa-dev] [PATCH 3/3] glsl: Move _mesa_shader_stage_to_string/abbrev to shader_enums.c

[Kristian Høgsberg Kristensen]

Matt Turner <mattst88 at gmail.com> writes:

> On Fri, Jan 8, 2016 at 2:36 PM, Kristian Høgsberg <krh at bitplanet.net> wrote:
>> From: Kristian Høgsberg Kristensen <krh at owl.jf.intel.com>
>>
>> These are used by code that doens't necessarily link to libglsl.la. Move
>
> typo: doesn't
>
>> them to shader_enums.[ch] where we keep similar helpers.
>> ---
>
> Does this work for you? I get

No, we're missing extern "C" in shader_enums.h. I'll send out v2.

Kristian

>   CXXLD    glsl_compiler
> ./.libs/libglsl.a(glsl_parser_extras.o): In function
> `_mesa_glsl_process_extension(char const*, YYLTYPE*, char const*,
> YYLTYPE*, _mesa_glsl_parse_state*)':
> /home/mattst88/projects/mesa-debug/src/glsl/../../../mesa/src/glsl/glsl_parser_extras.cpp:725:
> undefined reference to `_mesa_shader_stage_to_string(unsigned int)'
> /home/mattst88/projects/mesa-debug/src/glsl/../../../mesa/src/glsl/glsl_parser_extras.cpp:729:
> undefined reference to `_mesa_shader_stage_to_string(unsigned int)'
> ./.libs/libglsl.a(linker.o): In function
> `analyze_clip_usage(gl_shader_program*, gl_shader*, unsigned int*)':
> /home/mattst88/projects/mesa-debug/src/glsl/../../../mesa/src/glsl/linker.cpp:678:
> undefined reference to `_mesa_shader_stage_to_string(unsigned int)'
> ./.libs/libglsl.a(linker.o): In function
> `link_intrastage_shaders(void*, gl_context*, gl_shader_program*,
> gl_shader**, unsigned int)':
> /home/mattst88/projects/mesa-debug/src/glsl/../../../mesa/src/glsl/linker.cpp:2050:
> undefined reference to `_mesa_shader_stage_to_string(unsigned int)'
> ./.libs/libglsl.a(linker.o): In function `check_resources(gl_context*,
> gl_shader_program*)':
> /home/mattst88/projects/mesa-debug/src/glsl/../../../mesa/src/glsl/linker.cpp:2790:
> undefined reference to `_mesa_shader_stage_to_string(unsigned int)'
> ./.libs/libglsl.a(linker.o):/home/mattst88/projects/mesa-debug/src/glsl/../../../mesa/src/glsl/linker.cpp:2800:
> more undefined references to `_mesa_shader_stage_to_string(unsigned
> int)' follow