[Mesa-dev] [Bug 92137] [regression, bisected] piglit arb_separate_shader_objects.validateprogrampipeline fails

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=92137

--- Comment #6 from Tapani Pälli <lemody at gmail.com> ---
Fixed by
--- 8< ----
commit c3ec12ec3c1ddbc72e50df1f5632fe0547a89f7e
Author: Timothy Arceri <timothy.arceri at collabora.com>
Date:   Thu Nov 26 21:32:48 2015 +1100

    glsl: don't generate extra errors in ValidateProgramPipeline

    From Section 11.1.3.11 (Validation) of the GLES 3.1 spec:

       "An INVALID_OPERATION error is generated by any command that trans-
       fers vertices to the GL or launches compute work if the current set
       of active program objects cannot be executed, for reasons including:"

    It then goes on to list the rules we validate in the
    _mesa_validate_program_pipeline() function.

    For ValidateProgramPipeline the only mention of generating an error is:

       "An INVALID_OPERATION error is generated if pipeline is not a name re-
       turned from a previous call to GenProgramPipelines or if such a name has
       since been deleted by DeleteProgramPipelines,"

    Which we handle separately.

    This fixes:
    ES31-CTS.sepshaderobjs.PipelineApi

    No regressions on the eEQP 3.1 tests.

    Cc: Gregory Hainaut <gregory.hainaut at gmail.com>
    Reviewed-by: Tapani Pälli <tapani.palli at intel.com>

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20160114/83c67192/attachment.html>