[Mesa-dev] [PATCH] glsl: expose accurate gl_MaxCompute* constants rather than cooked values

[Timothy Arceri]

On Wed, 2016-01-20 at 03:51 -0500, Ilia Mirkin wrote:
> On Wed, Jan 20, 2016 at 3:48 AM, Timothy Arceri <
> t_arceri at yahoo.com.au> wrote:
> > > diff --git a/src/glsl/main.cpp b/src/glsl/main.cpp
> > > index c9432f1..bdf2f07 100644
> > > --- a/src/glsl/main.cpp
> > > +++ b/src/glsl/main.cpp
> > > @@ -63,6 +63,10 @@ initialize_context(struct gl_context *ctx,
> > > gl_api
> > > api)
> > >     ctx->Const.Program[MESA_SHADER_COMPUTE].MaxUniformComponents
> > > =
> > > 1024;
> > 
> > I think the above default is wrong too, it should be 512.
> 
> Any number >= 512 should be legal, I think. Note that this is
> exclusively used by the standalone glsl compiler.

Right I missed the this was in the standalone compiler.

Otherwise this patch looks good to me.

Reviewed-by: Timothy Arceri <timothy.arceri at collabora.com>

> 
>   -ilia