[Mesa-dev] [PATCH 2/2] st/mesa: enable OES_geometry_shader if GLSL 1.50 is supported

[Ilia Mirkin]

On Fri, Jan 22, 2016 at 3:00 PM, Ian Romanick <idr at freedesktop.org> wrote:
> On 01/22/2016 10:21 AM, Ilia Mirkin wrote:
>> Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu>
>> ---
>>  src/mesa/state_tracker/st_extensions.c | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/src/mesa/state_tracker/st_extensions.c b/src/mesa/state_tracker/st_extensions.c
>> index 01ba015..af99f5b 100644
>> --- a/src/mesa/state_tracker/st_extensions.c
>> +++ b/src/mesa/state_tracker/st_extensions.c
>> @@ -764,6 +764,9 @@ void st_init_extensions(struct pipe_screen *screen,
>>        extensions->AMD_vertex_shader_layer = GL_TRUE;
>>     }
>>
>> +   if (consts->GLSLVersion >= 150)
>> +      extensions->OES_geometry_shader = GL_TRUE;
>> +
>
> Should this also depend on GLES 3.1 being enabled?  I think this will
> cause any GLES 3.0 driver to start advertising an extension that won't
> actually work.

The ext in extensions.c actually specifies GLES 3.1 as a minimum so in
practice it wouldn't be advertised. (And actually GLSL 1.50 isn't
enough, because we need instancing, so I'll have to switch this to
something more selective.)

>
> Also... GL_OES_shader_io_blocks?

Erm, I thought we had that :) I guess not? I just saw the
OES_geometry_shader stuff getting pushed.

Either way, please consider this patch dropped.

  -ilia