[Mesa-dev] [PATCH] mesa: invalidate framebuffer when changing parameters
Ilia Mirkin
imirkin at alum.mit.edu
Sat Jan 23 06:35:52 PST 2016
This fixes dEQP-GLES31.functional.fbo.completeness.no_attachments
When the width or height are 0, the framebuffer is incomplete. We may
also not have been passing the new state down to the driver when the
widths/heights changed.
Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu>
---
Tested on nvc0, relying on some unreviewed patches, but I think this
makes sense... I was wondering how the driver was supposed to find out
about changes to these params and was manually dirtying at draw time,
but this seems way better.
src/mesa/main/fbobject.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c
index 3be216d..393a50c 100644
--- a/src/mesa/main/fbobject.c
+++ b/src/mesa/main/fbobject.c
@@ -1414,6 +1414,8 @@ framebuffer_parameteri(struct gl_context *ctx, struct gl_framebuffer *fb,
_mesa_error(ctx, GL_INVALID_ENUM,
"%s(pname=0x%x)", func, pname);
}
+
+ invalidate_framebuffer(fb);
}
void GLAPIENTRY
--
2.4.10
More information about the mesa-dev
mailing list