[Mesa-dev] [PATCH 1/2] winsys/amdgpu: Handle RADEON_FLAG_NO_CPU_ACCESS

[eocallaghan at alterapraxis.com]

This series is,

Reviewed-by: Edward O'Callaghan <eocallaghan at alterapraxis.com>

Good job working out where this issue was.

On 2016-01-26 18:40, Michel Dänzer wrote:
> From: Michel Dänzer <michel.daenzer at amd.com>
> 
> Failing to do this was resulting in the kernel driver unnecessarily
> leaving open the possibility of CPU access to tiled BOs.
> 
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=93862
> 
> (This change shouldn't be backported to stable branches, because
> released versions of xf86-video-amdgpu unnecessarily try to map the
> front buffer)
> 
> Signed-off-by: Michel Dänzer <michel.daenzer at amd.com>
> ---
>  src/gallium/winsys/amdgpu/drm/amdgpu_bo.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/src/gallium/winsys/amdgpu/drm/amdgpu_bo.c
> b/src/gallium/winsys/amdgpu/drm/amdgpu_bo.c
> index 30a1aa8..1e997d9 100644
> --- a/src/gallium/winsys/amdgpu/drm/amdgpu_bo.c
> +++ b/src/gallium/winsys/amdgpu/drm/amdgpu_bo.c
> @@ -292,6 +292,8 @@ static struct amdgpu_winsys_bo
> *amdgpu_create_bo(struct amdgpu_winsys *ws,
>        request.preferred_heap |= AMDGPU_GEM_DOMAIN_VRAM;
>        if (flags & RADEON_FLAG_CPU_ACCESS)
>           request.flags |= AMDGPU_GEM_CREATE_CPU_ACCESS_REQUIRED;
> +      if (flags & RADEON_FLAG_NO_CPU_ACCESS)
> +         request.flags |= AMDGPU_GEM_CREATE_NO_CPU_ACCESS;
>     }
>     if (initial_domain & RADEON_DOMAIN_GTT) {
>        request.preferred_heap |= AMDGPU_GEM_DOMAIN_GTT;