[Mesa-dev] [PATCH 1/2] winsys/amdgpu: Handle RADEON_FLAG_NO_CPU_ACCESS

Christian König deathsimple at vodafone.de
Tue Jan 26 00:47:09 PST 2016


Am 26.01.2016 um 08:40 schrieb Michel Dänzer:
> From: Michel Dänzer <michel.daenzer at amd.com>
>
> Failing to do this was resulting in the kernel driver unnecessarily
> leaving open the possibility of CPU access to tiled BOs.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=93862
>
> (This change shouldn't be backported to stable branches, because
> released versions of xf86-video-amdgpu unnecessarily try to map the
> front buffer)
>
> Signed-off-by: Michel Dänzer <michel.daenzer at amd.com>

For those two Reviewed-by: Christian König <christian.koenig at amd.com>.

> ---
>   src/gallium/winsys/amdgpu/drm/amdgpu_bo.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/src/gallium/winsys/amdgpu/drm/amdgpu_bo.c b/src/gallium/winsys/amdgpu/drm/amdgpu_bo.c
> index 30a1aa8..1e997d9 100644
> --- a/src/gallium/winsys/amdgpu/drm/amdgpu_bo.c
> +++ b/src/gallium/winsys/amdgpu/drm/amdgpu_bo.c
> @@ -292,6 +292,8 @@ static struct amdgpu_winsys_bo *amdgpu_create_bo(struct amdgpu_winsys *ws,
>         request.preferred_heap |= AMDGPU_GEM_DOMAIN_VRAM;
>         if (flags & RADEON_FLAG_CPU_ACCESS)
>            request.flags |= AMDGPU_GEM_CREATE_CPU_ACCESS_REQUIRED;
> +      if (flags & RADEON_FLAG_NO_CPU_ACCESS)
> +         request.flags |= AMDGPU_GEM_CREATE_NO_CPU_ACCESS;
>      }
>      if (initial_domain & RADEON_DOMAIN_GTT) {
>         request.preferred_heap |= AMDGPU_GEM_DOMAIN_GTT;



More information about the mesa-dev mailing list