[Mesa-dev] [PATCH v5] mesa: enable enums for OES_geometry_shader

Ilia Mirkin imirkin at alum.mit.edu
Tue Jan 26 09:00:59 PST 2016


On Tue, Jan 26, 2016 at 3:48 AM, Marta Lofstedt
<marta.lofstedt at linux.intel.com> wrote:
> From: Marta Lofstedt <marta.lofstedt at intel.com>
>
> Enable GL_OES_geometry_shader enums for OpenGL ES 3.1.
>
> V4: EXTRA tokens updated according to comments from Ilia Mirkin.
>
> V5: Account for check_extra does not evaluate "or" lazy. Fix issues
> with EXTRA_EXT_FB_NO_ATTACH_CS.

Oh! So all of those were essentially broken since they overrode any
other results. Tricky. I was wondering why we were seeing failures
since the conditions *seemed* correct.

Assuming the only thing you changed from the last attempt was merging
my layers change to still be exposed in gl compat and fixing api_found
= x into if (x) api_found = true, then this still has my R-b. (Little
good it did last time though...)

  -ilia


More information about the mesa-dev mailing list