[Mesa-dev] [PATCH v5] mesa: enable enums for OES_geometry_shader

[Lofstedt, Marta]

> -----Original Message-----
> From: mesa-dev [mailto:mesa-dev-bounces at lists.freedesktop.org] On
> Behalf Of Ilia Mirkin
> Sent: Tuesday, January 26, 2016 6:01 PM
> To: Marta Lofstedt
> Cc: mesa-dev at lists.freedesktop.org; Marek Olšák
> Subject: Re: [Mesa-dev] [PATCH v5] mesa: enable enums for
> OES_geometry_shader
> 
> On Tue, Jan 26, 2016 at 3:48 AM, Marta Lofstedt
> <marta.lofstedt at linux.intel.com> wrote:
> > From: Marta Lofstedt <marta.lofstedt at intel.com>
> >
> > Enable GL_OES_geometry_shader enums for OpenGL ES 3.1.
> >
> > V4: EXTRA tokens updated according to comments from Ilia Mirkin.
> >
> > V5: Account for check_extra does not evaluate "or" lazy. Fix issues
> > with EXTRA_EXT_FB_NO_ATTACH_CS.
> 
> Oh! So all of those were essentially broken since they overrode any other
> results. Tricky. I was wondering why we were seeing failures since the
> conditions *seemed* correct.
> 
> Assuming the only thing you changed from the last attempt was merging my
> layers change to still be exposed in gl compat and fixing api_found = x into if
> (x) api_found = true, then this still has my R-b. (Little good it did last time
> though...)
> 
Thanks Ilia, 

This was of course all my bad, I should of course have run piglit on what I actually was merging and not with also having oes_geometry_shader enabled in i965.


>   -ilia
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev