[Mesa-dev] [PATCH 10/14] isl: Add support for HiZ surfaces

[Jason Ekstrand]

On Jul 12, 2016 4:14 PM, "Chad Versace" <chad.versace at intel.com> wrote:
>
> On Tue 12 Jul 2016, Jason Ekstrand wrote:
> > On Tue, Jul 12, 2016 at 2:36 PM, Chad Versace <chad.versace at intel.com>
> > wrote:
> >
> > > Also, isl.c needs an update in this hunk:
> > >
> > >    # isl.c
> > >    if (isl_surf_usage_is_depth_or_stencil(info->usage)) {
> > >       /* From the Ivybridge PRM >> Volume 1 Part 1: Graphics Core >>
> > >        * Section 6.18.4.7: Surface Arrays (p112):
> > >        *
> > >        *    If Surface Array Spacing is set to ARYSPC_FULL (note that
> > >        *    the depth buffer and stencil buffer have an implied value
> > >        *    ARYSPC_FULL):
> > >        */
> > >       return ISL_ARRAY_PITCH_SPAN_COMPACT;
> > >    }
> > >
> >
> > Right.  I think we also need to fix that to be PITCH_SPAN_FULL because
it
> > looks like it directly contradicts the comment.  I'll add that as a
fixup
> > patch at the beginning of the series and update the HiZ patch to do the
> > right thing here.
>
> Ok. I'll wait for that to hit your branch before I r-b.

Already there
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20160712/9228bb35/attachment.html>