[Mesa-dev] [PATCH 11/29] mesa: Use bitmask/ffs to iterate enabled lights for building ff shader keys.

Mathias Fröhlich Mathias.Froehlich at gmx.net
Thu Jun 2 06:43:34 UTC 2016


Hi Erik,

On Tuesday, May 31, 2016 16:41:46 Erik Faye-Lund wrote:
> On Sat, May 28, 2016 at 12:31 PM, Mathias Fröhlich
> <Mathias.Froehlich at gmx.net> wrote:
> > So the xor mask handing is non local to the place where we do the
> > computation of i.
> >
> > Brian pointed me to the u_bit_scan function heavily used in gallium. That
> > definitely
> >
> > helps for the basic problem I personally have with this type of loops.
> >
> > Does that also somehow help for your concerns?
> 
> Yes; u_bit_scan or similar mitigates my concerns!

Ok, Thanks. I do prepare an updated series anyway.

Mathias
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20160602/4c957ffe/attachment.html>


More information about the mesa-dev mailing list