[Mesa-dev] [PATCH] st/osmesa: remove double-write (overwriting)

Eric Engestrom eric.engestrom at imgtec.com
Thu Jun 2 09:29:03 UTC 2016


On Tue, May 31, 2016 at 06:33:53AM -0600, Brian Paul wrote:
> On 05/30/2016 07:26 PM, Eric Engestrom wrote:
> > These two lines have been here since the file was created.
> > I'm guessing the second one was just for testing during dev, so it's the
> > one that's going away.
> > 
> > CoverityID: 1296205
> > 
> > Signed-off-by: Eric Engestrom <eric at engestrom.ch>
> > ---
> > 
> > This should probably be tested by someone who knows what they're doing :]
> > 
> > ---
> >   src/gallium/state_trackers/osmesa/osmesa.c | 1 -
> >   1 file changed, 1 deletion(-)
> > 
> > diff --git a/src/gallium/state_trackers/osmesa/osmesa.c b/src/gallium/state_trackers/osmesa/osmesa.c
> > index 1071507..18f1b88 100644
> > --- a/src/gallium/state_trackers/osmesa/osmesa.c
> > +++ b/src/gallium/state_trackers/osmesa/osmesa.c
> > @@ -877,7 +877,6 @@ OSMesaGetIntegerv(GLint pname, GLint *value)
> >            int maxLevels = screen->get_param(screen,
> >                                              PIPE_CAP_MAX_TEXTURE_2D_LEVELS);
> >            *value = 1 << (maxLevels - 1);
> > -         *value = 8 * 1024;
> >         }
> >         return;
> >      default:
> > 
> 
> Reviewed-by: Brian Paul <brianp at vmware.com>
> 
> Need me to push this for you?

Yes please :)


More information about the mesa-dev mailing list