[Mesa-dev] [PATCH v3] clover: Update OpenCL version string to match OpenGL

[Jan Vesely]

On Fri, 2016-06-03 at 18:58 +0200, Vedran Miletić wrote:
> On 06/03/2016 06:32 PM, Emil Velikov wrote:
> > 
> > Not sure who much the MESA>Mesa change matters, so I'll leave that
> > to others.
> > 
> Could break some applications that check for it. I doubt many do, and
> if 
> they do I would suggest to make the change before Clover becomes 
> popular, in hope this will be the case at some point.
> 
> > 
> > > 
> > > +#ifdef MESA_GIT_SHA1
> > > +                        " (" MESA_GIT_SHA1 ")"
> > > +#endif
> > ... but here please drop the ifdef guard. Same goes for the other
> > file.
> > 
> This is how OpenGL does it. Do you mind if I drop the include guard 
> there as well?
> 
> > 
> > Please give it some time for others to weight in before sending out
> > v4.

it's also a nice touch if you include changes between versions when
sending patches. it saves others the trouble to diff the diff.

Jan


> > 
> Sure. Sorry for multiple revisions initially.
> 
> Regards,
> Vedran
> 
-- 
Jan Vesely <jan.vesely at rutgers.edu>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20160603/9687ff3f/attachment.sig>