[Mesa-dev] [PATCH v3] clover: Update OpenCL version string to match OpenGL

[Emil Velikov]

On 3 June 2016 at 17:58, Vedran Miletić <vedran at miletic.net> wrote:
> On 06/03/2016 06:32 PM, Emil Velikov wrote:
>>
>> Not sure who much the MESA>Mesa change matters, so I'll leave that to
>> others.
>>
>
> Could break some applications that check for it. I doubt many do, and if
> they do I would suggest to make the change before Clover becomes popular, in
> hope this will be the case at some point.
>
>>> +#ifdef MESA_GIT_SHA1
>>> +                        " (" MESA_GIT_SHA1 ")"
>>> +#endif
>>
>> ... but here please drop the ifdef guard. Same goes for the other file.
>>
>
> This is how OpenGL does it. Do you mind if I drop the include guard there as
> well?
>
Unlike Clover, mesa/main is build with both Automake and SCons. And
since the Scons bits are not merged yet, the patch nuking the
mesa/main guards is sitting/waiting on the ML.

>> Please give it some time for others to weight in before sending out v4.
>>
>
> Sure. Sorry for multiple revisions initially.
>
Np. We live and we learn :-)

-Emil